[Base image files] All 'docker exec' wrapper scripts now dynamically adjust their flags depending on whether or not they are run on a terminal #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adjust their flags depending on whether or not they are run on a terminal
taoyl-ms
approved these changes
Mar 17, 2018
rodnymolina
approved these changes
Mar 17, 2018
lguohan
approved these changes
Mar 17, 2018
qiluo-msft
added a commit
that referenced
this pull request
Mar 17, 2021
Included commits: ``` 0d5fb48 2021-03-16 | [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1507) [maksymbelei95] ```
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
I re-added the copy_file method that was removed in a recent refactor. Buildimage tests depend on this method, so subsequent submodule updates will fail. Signed-off-by: Danny Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
-tflag todocker execwill fail if the command is being called when no on a terminal (e.g., from systemctl or cron).This commit will dynamically add the
tflag if it is determined that the command is being executed on a terminal. Otherwise, it will only pass thei(interactive) flag.